[ECO-5430] fix: npe in the connectivity check#1111
Merged
Conversation
WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant HttpHelpers
participant HttpCore
Caller->>HttpHelpers: getUrlString(httpCore, url)
HttpHelpers->>HttpHelpers: getUrl(httpCore, url)
HttpHelpers->>HttpCore: httpExecuteWithRetry(...)
HttpCore-->>HttpHelpers: Response (body: byte[])
alt body is not null
HttpHelpers-->>Caller: String from byte[]
else body is null
HttpHelpers-->>Caller: throw AblyException("Empty response body", 50000, 500)
end
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (11)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- Throw `AblyException` for empty response bodies. - Added corresponding unit tests to validate behavior.
ttypic
force-pushed
the
ECO-5430/fix-npe-on-check-conectivity
branch
from
9754520 to
c3591e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1110
handle empty response in
HttpHelpers.getUrlStringAblyExceptionfor empty response bodies.Summary by CodeRabbit
Bug Fixes
Tests